Skip to content

[skip-changelog] Proper handling of stdout/stderr copy in subprocess #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2022
Merged

[skip-changelog] Proper handling of stdout/stderr copy in subprocess #1862

merged 2 commits into from
Sep 6, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 3, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
=== RUN   TestCompletionNoArgs
>>> Running: /home/runner/work/arduino-cli/arduino-cli/arduino-cli completion
<<< Run completed (err = exit status 1)
    completion_test.go:32: 
        	Error Trace:	/home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/completion/completion_test.go:32
        	Error:      	"" does not contain "Error: accepts 1 arg(s), received 0"
        	Test:       	TestCompletionNoArgs
--- FAIL: TestCompletionNoArgs (0.01s)
  • What is the new behavior?
    The issue above should be fixed

@cmaglie cmaglie self-assigned this Sep 3, 2022
@codecov
Copy link

codecov bot commented Sep 3, 2022 •
edited
Loading

Codecov Report

Merging #1862 (b702e75) into master (67a62d9) will decrease coverage by 0.02%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master    #1862      +/-   ##
==========================================
- Coverage   36.65%   36.62%   -0.03%     
==========================================
  Files         231      231              
  Lines       19609    19610       +1     
==========================================
- Hits         7187     7182       -5     
- Misses      11596    11600       +4     
- Partials      826      828       +2
Flag Coverage Δ
unit 36.62% <45.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
executils/process.go 80.95% <ø> (ø)
internal/integrationtest/arduino-cli.go 83.19% <45.45%> (-2.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Sep 3, 2022
@cmaglie cmaglie requested a review from umbynos September 5, 2022 08:40
umbynos
umbynos reviewed Sep 5, 2022
View reviewed changes
umbynos
umbynos reviewed Sep 5, 2022
View reviewed changes
@cmaglie cmaglie merged commit 71cab65 into arduino:master Sep 6, 2022
@cmaglie cmaglie deleted the fix_integr_tests branch September 6, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@cmaglie cmaglie

Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @umbynos @per1234